From 47e48c490203493b48ed2a8db63513aff6978b73 Mon Sep 17 00:00:00 2001 From: Henry Winkel Date: Sat, 16 May 2026 21:14:58 +0200 Subject: [PATCH] fix: use useMemo for derived rawSettings and remove unused imports in SystemSettings --- app/components/SystemSettings.tsx | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/components/SystemSettings.tsx b/app/components/SystemSettings.tsx index cae46ba..5593a4a 100644 --- a/app/components/SystemSettings.tsx +++ b/app/components/SystemSettings.tsx @@ -1,4 +1,4 @@ -import React, { useState, useEffect } from "react"; +import { useMemo } from "react"; interface SystemSettingsProps { settings: Record; @@ -14,17 +14,15 @@ const KNOWN_KEYS = new Set([ ]); export default function SystemSettings({ settings, alpacaMode, onSave, saveError }: SystemSettingsProps) { - const [rawSettings, setRawSettings] = useState>([]); - - useEffect(() => { - const others = Object.entries(settings) + const rawSettings = useMemo(() => + Object.entries(settings) .filter(([key]) => !KNOWN_KEYS.has(key)) .map(([key, value]) => ({ key, value: typeof value === "string" ? value : JSON.stringify(value, null, 2), - })); - setRawSettings(others); - }, [settings]); + })), + [settings] + ); const handleRawSave = async (key: string, newValue: string) => { try {